Skip to content

8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove #25931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove #25931

wants to merge 1 commit into from

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jun 23, 2025 •
edited by openjdk bot
Loading

No need to call List.indexOf(Object) before List.remove(int). Instead we can call List.remove(Object) directly. It's faster and cleaner.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25931/head:pull/25931
$ git checkout pull/25931

Update a local copy of the PR:
$ git checkout pull/25931
$ git pull https://git.openjdk.org/jdk.git pull/25931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25931

View PR using the GUI difftool:
$ git pr show -t 25931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25931.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 23, 2025

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025 •
edited
Loading

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove

Reviewed-by: azvegint, serb, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 47 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mrserb
Copy link
Member

mrserb commented Jun 23, 2025

looks fine

@turbanoff turbanoff changed the title [PATCH] Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove 8360487: Remove unnecessary List.indexOf key from AbstractMidiDevice.TransmitterList.remove Jun 25, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 25, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 25, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 25, 2025
@mrserb
Copy link
Member

mrserb commented Jun 25, 2025

please rerun the Pre-submit tests in the GA

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 27, 2025

Going to push as commit 20e983a.
Since your change was applied there have been 64 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 27, 2025
@openjdk openjdk bot closed this Jun 27, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 27, 2025
@openjdk
Copy link

openjdk bot commented Jun 27, 2025

@turbanoff Pushed as commit 20e983a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrserb mrserb mrserb approved these changes

@aivanov-jdk aivanov-jdk aivanov-jdk approved these changes

@azvegint azvegint azvegint approved these changes

Assignees
No one assigned
Labels
client [email protected] integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@turbanoff @mrserb @aivanov-jdk @azvegint